Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deduplicate the __name__ label in the metrics collector #1778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thibaultmg
Copy link
Contributor

@thibaultmg thibaultmg commented Jan 14, 2025

All labels are deduplicated, except this one. We have a client configuration where this happens. Adding it to the deduplication process.
Fixes https://issues.redhat.com/browse/ACM-17056

@thibaultmg
Copy link
Contributor Author

/retest

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg thibaultmg force-pushed the ACM_17056_dedup_name_label branch from 9006f8b to 84a2d0d Compare January 15, 2025 12:26
@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

New changes are detected. LGTM label has been removed.

@thibaultmg
Copy link
Contributor Author

/cherry-pick. release-2.11

@thibaultmg
Copy link
Contributor Author

/cherry-pick release-2.11

@openshift-cherrypick-robot
Copy link
Collaborator

@thibaultmg: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jan 15, 2025

@thibaultmg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 84a2d0d link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thibaultmg
Copy link
Contributor Author

/retest

@thibaultmg
Copy link
Contributor Author

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Collaborator

@thibaultmg: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants